Skip to content
This repository was archived by the owner on Dec 10, 2023. It is now read-only.

chore: migrate to main branch#239

Merged
gcf-merge-on-green[bot] merged 6 commits intomainfrom
to_main
Aug 27, 2021
Merged

chore: migrate to main branch#239
gcf-merge-on-green[bot] merged 6 commits intomainfrom
to_main

Conversation

@dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Aug 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #238 🦕

@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 02:00
@product-auto-label product-auto-label bot added the api: dlp Issues related to the googleapis/python-dlp API. label Aug 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@dandhlee dandhlee requested a review from parthea August 24, 2021 02:00
@dandhlee
Copy link
Contributor Author

dandhlee commented Aug 24, 2021

See #234 for the Samples failures

@parthea parthea changed the title docs: migrate to main branch chore: migrate to main branch Aug 25, 2021
parthea
parthea reviewed Aug 25, 2021
View reviewed changes
@parthea parthea mentioned this pull request Aug 27, 2021
Closed
@dandhlee dandhlee requested a review from parthea August 27, 2021 18:24
@dandhlee
Copy link
Contributor Author

dandhlee commented Aug 27, 2021

Please take a look again!

@google-cla
Copy link

google-cla bot commented Aug 27, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 27, 2021
@parthea
Copy link
Contributor

parthea commented Aug 27, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 27, 2021
@dandhlee dandhlee added the automerge Merge the pull request once unit tests and other checks pass. label Aug 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 912b39c into main Aug 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the to_main branch August 27, 2021 21:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@parthea parthea parthea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dlp Issues related to the googleapis/python-dlp API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to main branch

2 participants

@dandhlee @parthea